Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special for loop variables class, to support all attribute resolvers #560

Merged
merged 1 commit into from
Dec 11, 2020
Merged

Special for loop variables class, to support all attribute resolvers #560

merged 1 commit into from
Dec 11, 2020

Conversation

ogrammer
Copy link
Contributor

I have disabled accessing map entries as fields in my attribute resolver, so using for loop variables does not work.

I see no reason to not use a special class instead of a map. Probably has a tiny bit better performance as well and it is type-safe.

@ebussieres ebussieres added this to the 3.1.5 milestone Dec 11, 2020
@ebussieres ebussieres merged commit 3bddb10 into PebbleTemplates:master Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants